[rust] Modified api.mustache to ensure correct handling of Vec<PathBuf> while adding files to multipart form
#22942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 7 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="modules/openapi-generator/src/main/resources/rust/reqwest/api.mustache">
<violation number="1" location="modules/openapi-generator/src/main/resources/rust/reqwest/api.mustache:408">
P2: Async multipart handling for required nullable file arrays iterates over `&Option<Vec<PathBuf>>` without unwrapping, producing `&Vec<PathBuf>` loop values that cannot be opened as paths; this causes compile errors for required nullable file arrays.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| {{#required}} | ||
| {{^isNullable}} | ||
| {{#isArray}} | ||
| for value in &{{{vendorExtensions.x-rust-param-identifier}}} { |
Contributor
There was a problem hiding this comment.
P2: Async multipart handling for required nullable file arrays iterates over &Option<Vec<PathBuf>> without unwrapping, producing &Vec<PathBuf> loop values that cannot be opened as paths; this causes compile errors for required nullable file arrays.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At modules/openapi-generator/src/main/resources/rust/reqwest/api.mustache, line 408:
<comment>Async multipart handling for required nullable file arrays iterates over `&Option<Vec<PathBuf>>` without unwrapping, producing `&Vec<PathBuf>` loop values that cannot be opened as paths; this causes compile errors for required nullable file arrays.</comment>
<file context>
@@ -404,37 +404,85 @@ pub {{#supportAsync}}async {{/supportAsync}}fn {{{operationId}}}(configuration:
{{#required}}
{{^isNullable}}
+ {{#isArray}}
+ for value in &{{{vendorExtensions.x-rust-param-identifier}}} {
+ multipart_form = multipart_form.file("{{{baseName}}}", value)?;
+ }
</file context>
Member
|
thanks for the PR if no feedback/question from anyone, i'll try to merge it later this week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a section for when the file field is an array. If it is an array, we iterate through the files and use the same logic we had before to add it to the form. Modified it for both async and non async sections. Ran the tests with the following parameters with example mentioned in #22900. Fixes #22900 @frol @farcaller @richardwhiuk @paladinzh @jacob-pro @dsteeley :
supportAsync = true
supportAsync = false
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Fixes incorrect handling of multipart file arrays in Rust reqwest clients. When a form field is Vec, each file is now added to the multipart body in both async and sync paths. Fixes #22900.
Written for commit 76bd2e5. Summary will update on new commits.